Update build toolchain on 5.0.2 line #228
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
|
I think spending time on a deprecated plugin is a waste of time. I therefore tried to fix the test cases of the JUnit plugin: jenkinsci/junit-plugin#272. Then we can mark bootstrap4 plugin as deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
junitmust be in the BOM, as it is one of the most popular plugins.junitis in the BOM, all of its current dependencies must be in the BOM.junit's current dependencies includebootstrap4-apiand thereforeecharts-api<= 5.0.2.echarts-api<= 5.0.2 must remain in the BOM, its build toolchain must be kept up-to-date.commit de25291 in this PR is based on top of
echarts-api5.0.2-1. It updates the build toolchain. I am asking that we backport these build toolchain updates to the 5.0.2 line and release 5.0.2-2. This would allow us to update the 5.0.2 version ofecharts-apiin the BOM, even without jenkinsci/junit-plugin#342, and unblock my other BOM work in the short term. For instructions on how to do a backport, see: https://gist.github.com/jglick/86a30894446ed38f918050c1180483e2